Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the copy in the sending address confirmation box #2024

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

smcmurtry
Copy link
Contributor

Summary | Résumé

Update the copy in the sending address confirmation box: "Make sure..." -> "Check that... "

Zenhub card: https://app.zenhub.com/workspaces/notify-planning-614b3ad91bc2030015ed22f5/issues/gh/cds-snc/notification-planning/1239
Translations: https://www.figma.com/design/1ccAvKpMboyDmnUliunnBY/Onboarding-and-set-up-%7C-Embarquement-et-configuration?node-id=2598-4902&t=ZRJDMEYYj69goMSj-0

Before

Screenshot 2024-12-30 at 2 18 08 PM

After

Screenshot 2024-12-30 at 3 41 37 PM Screenshot 2024-12-30 at 3 42 21 PM

Test instructions | Instructions pour tester la modification

  • Log into the review environment
  • create a new service
  • On Step 2, enter your new service's email address
  • verify that the copy in the confirmation box has been updated correctly in french and english
  • check that the service settings page was also updated

Copy link

Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jzbahrai jzbahrai enabled auto-merge (squash) January 6, 2025 18:45
@jzbahrai jzbahrai merged commit c1adf96 into main Jan 6, 2025
10 of 11 checks passed
@jzbahrai jzbahrai deleted the fix/update-sending-address-copy branch January 6, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants